fix: Use Spark session timezone in native execution when creating Arrow schema [WIP] #2734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2734 +/- ##
============================================
+ Coverage 56.12% 57.23% +1.10%
- Complexity 976 1371 +395
============================================
Files 119 147 +28
Lines 11743 13843 +2100
Branches 2251 2376 +125
============================================
+ Hits 6591 7923 +1332
- Misses 4012 4692 +680
- Partials 1140 1228 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@parthchandra @mbutrovich I'm not looking for a review yet, but I'd like to discuss this with you both next week. I understand the issue much better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partial fix for #2649
Rationale for this change
In native code, we had a hard-coded
UTCwhen converting Spark schema to Arrow schema.In
to_arrow_datatype:This would lead to a runtime error when running a query against a DataFrame (not a Parquet file) that is not in
UTC:What changes are included in this PR?
Pass Spark timeZoneId into native code and use that instead of hard-coded
UTC.How are these changes tested?
WIP